Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index signatures on unions of intersections #38278

Merged
merged 2 commits into from
May 4, 2020
Merged

Fix index signatures on unions of intersections #38278

merged 2 commits into from
May 4, 2020
+210 −1

Conversation

ahejlsberg
Copy link
Member

Fixes #38102.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 30, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at c635e43. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 30, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at c635e43. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Apr 30, 2020 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at c635e43. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@typescript-bot typescript-bot mentioned this pull request Apr 30, 2020
Open
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 4, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.9 on this PR at c635e43. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request May 4, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #38330 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 4, 2020
@ahejlsberg @typescript-bot
Cherry-pick PR microsoft#38278 into release-3.9
5e66282 
Component commits:
d905ced Add missing getApparentType call

c635e43 Add regression tests
@ahejlsberg ahejlsberg merged commit a09470f into master May 4, 2020
@DanielRosenwasser DanielRosenwasser deleted the fix38102 branch May 4, 2020 19:47
DanielRosenwasser pushed a commit that referenced this pull request May 5, 2020
@ahejlsberg
Cherry-pick PR #38278 into release-3.9 (#38330)
90570df 
Component commits:
d905ced Add missing getApparentType call

c635e43 Add regression tests

Co-authored-by: Anders Hejlsberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@amcasey amcasey Awaiting requested review from amcasey

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New error in 3.9: TS 7053 - can't index with number
3 participants
@ahejlsberg @typescript-bot @DanielRosenwasser